Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multitargeting with core #1

Merged
merged 3 commits into from
Jan 15, 2019

Conversation

virzak
Copy link
Contributor

@virzak virzak commented Jan 11, 2019

You'll need the latest daily build for dotnet core 3

Bulid using dotnet build
Run the demo with dotnet run --framework net45 or dotnet run --framework netcoreapp3.0

Original library targets 4.0, but there is an issue with that right now. Hopefully gets resolved soon, through library update or a workaround.

This issue can be addressed after the merge Dirkster99/InplaceEditBoxLib#4

Update: updated the library to target 4.0 using the workaround, so there is 0 impact on end-users

Update 2: Packing should be super easy dotnet pack -c Release. All package info is in the csproj file.

@Dirkster99 Dirkster99 changed the base branch from master to NetCoreMultiTargeting January 15, 2019 09:21
@Dirkster99 Dirkster99 merged commit 033f1d6 into Dirkster99:NetCoreMultiTargeting Jan 15, 2019
@Dirkster99
Copy link
Owner

Hi Victor,

thanks for the input. I have merged this into a separate branch called NetCoreMultiTargeting since master seems to be to early right now. I need to lookup and process your description to really understand the consequences of this change. To speed me up - would you be able to give me a step by step description of what I should do to verify how the new version from the pull request should work? I am looking for something like this:

  • download and install .NetCore daily build from here (link and version for Windows 10?)
  • Open the NetCoreMultiTargeting branch in VS
    or use cmd to issue command xyz on source from the branch ???
  • Select Option X,Y,Z and Start ...

This would be really helpful as I would otherwise have to research this and I just do not have that much experience with dotnet yet ...thanks

@virzak
Copy link
Contributor Author

virzak commented Jan 15, 2019

The most important thing about this change is that the consequences are minimal for consumers of this library. They are not different from any other update. The code is unchanged and .net framework assembly is the same as before. This is an addition of .net core target framework.

Minimum requirements:

  • Download the daily build of .net core 3.0 SDK
  • Run dotnet pack -c Release in the UserNotifications\source\UserNotification directory. This will build and package a pre-release version.
  • Deploy nupkg to Nuget (public, private, or a local folder). It will be a pre-release version
  • In a consuming project (InplaceEditBoxLib or other) enable "prerelease" and download the newly deployed version of the package.
    • In case of InplaceEditBoxLib it is important to run CleanAll.bat and ensure all projects are updated to the same version of UserNotification.
  • Rebuild the solution and run a demo (InPlaceEditBoxDemo or other) to ensure the upgrade hasn't broken anything.

More details:

  • The new branch can be build with dotnet build
  • The demo project (also multitargeted) can be run with either framework, which needs to be specified.
    • In VS 2019 you can select the framework using UI
      image
    • You can run using dotnet run --framework net45 or dotnet run --framework netcoreapp3.0 from command line

@Dirkster99
Copy link
Owner

Thanks for the detailed explanation. I'll try to get through this ASAP - not sure when exactly but I should be able to have the preview nuget by Friday evenning'ish or so - I'll get back to you ASAP, thanks

@virzak virzak deleted the netcoreapp branch January 16, 2019 14:55
@Dirkster99
Copy link
Owner

I am not really able to spend much time on it today but I managed to execute the first steps towards installing the Net Core 3.0 bits and compilling the project - it works a prescribed :-) only problem I found is the transparanet background #2 which I remember having seen before but do not remember the cause - so I'll be looking into this tomorrow and hopefully be finding the source of the problem

  • more likely then not the application isn't loading the styles in App.xaml? or something like this - I'll be in touch, cheers.

@virzak
Copy link
Contributor Author

virzak commented Jan 16, 2019

@Dirkster99 Thanks, I'll look into this too if I get a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants