-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multitargeting with core #1
multitargeting with core #1
Conversation
Hi Victor, thanks for the input. I have merged this into a separate branch called NetCoreMultiTargeting since master seems to be to early right now. I need to lookup and process your description to really understand the consequences of this change. To speed me up - would you be able to give me a step by step description of what I should do to verify how the new version from the pull request should work? I am looking for something like this:
This would be really helpful as I would otherwise have to research this and I just do not have that much experience with dotnet yet ...thanks |
The most important thing about this change is that the consequences are minimal for consumers of this library. They are not different from any other update. The code is unchanged and .net framework assembly is the same as before. This is an addition of .net core target framework. Minimum requirements:
More details:
|
Thanks for the detailed explanation. I'll try to get through this ASAP - not sure when exactly but I should be able to have the preview nuget by Friday evenning'ish or so - I'll get back to you ASAP, thanks |
I am not really able to spend much time on it today but I managed to execute the first steps towards installing the Net Core 3.0 bits and compilling the project - it works a prescribed :-) only problem I found is the transparanet background #2 which I remember having seen before but do not remember the cause - so I'll be looking into this tomorrow and hopefully be finding the source of the problem
|
@Dirkster99 Thanks, I'll look into this too if I get a chance |
You'll need the latest daily build for dotnet core 3
Bulid using
dotnet build
Run the demo with
dotnet run --framework net45
ordotnet run --framework netcoreapp3.0
Original library targets 4.0, but there is an issue with that right now. Hopefully gets resolved soon, through library update or a workaround.
This issue can be addressed after the merge Dirkster99/InplaceEditBoxLib#4
Update: updated the library to target 4.0 using the workaround, so there is 0 impact on end-users
Update 2: Packing should be super easy
dotnet pack -c Release
. All package info is in the csproj file.