Update Rust crate serde to 1.0.191 #217
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
1 error and 7 warnings
Scan
This version of the CodeQL Action was deprecated on January 18th, 2023, and is no longer updated or supported. For better performance, improved security, and new features, upgrade to v2. For more information, see https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/
|
this expression borrows a value the compiler would automatically borrow:
src/main.rs#L108
warning: this expression borrows a value the compiler would automatically borrow
--> src/main.rs:108:28
|
108 | match_name != "show" && !(&(actions)[&match_name_yaml]["args"].is_null()).to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(actions)[&match_name_yaml]["args"].is_null()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
binary comparison to literal `Option::None`:
src/main.rs#L99
warning: binary comparison to literal `Option::None`
--> src/main.rs:99:5
|
99 | if matches.subcommand() == None {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `matches.subcommand().is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
the loop variable `j` is only used to index `args_vec`:
src/main.rs#L83
warning: the loop variable `j` is only used to index `args_vec`
--> src/main.rs:83:14
|
83 | for j in 0..args_vec.len() {
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
|
83 | for <item> in &args_vec {
| ~~~~~~ ~~~~~~~~~
|
useless conversion to the same type: `linked_hash_map::Values<'_, yaml_rust::Yaml, yaml_rust::Yaml>`:
src/main.rs#L67
warning: useless conversion to the same type: `linked_hash_map::Values<'_, yaml_rust::Yaml, yaml_rust::Yaml>`
--> src/main.rs:67:48
|
67 | let values: Vec<&LinkedHashMap<Yaml, Yaml>> = actions
| ___________________________________________________^
68 | | .values()
69 | | .into_iter()
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing `.into_iter()`
|
67 ~ let values: Vec<&LinkedHashMap<Yaml, Yaml>> = actions
68 ~ .values()
|
|
useless conversion to the same type: `linked_hash_map::Keys<'_, yaml_rust::Yaml, yaml_rust::Yaml>`:
src/main.rs#L62
warning: useless conversion to the same type: `linked_hash_map::Keys<'_, yaml_rust::Yaml, yaml_rust::Yaml>`
--> src/main.rs:62:24
|
62 | let keys: Vec<&str> = actions
| ___________________________^
63 | | .keys()
64 | | .into_iter()
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into_iter()`
|
62 ~ let keys: Vec<&str> = actions
63 ~ .keys()
|
|
found module declaration for lib.rs:
src/main.rs#L2
warning: found module declaration for lib.rs
--> src/main.rs:2:1
|
2 | mod lib;
| ^^^^^^^^
|
= note: lib.rs is the root of this crate's library target
= help: to refer to it from other targets, use the library's name as the path
= note: `#[warn(special_module_name)]` on by default
|
Scan
The following actions uses node12 which is deprecated and will be forced to run on node16: github/codeql-action/upload-sarif@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|