Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking of entity picture generation #122

Merged

Conversation

Snuffy2
Copy link
Contributor

@Snuffy2 Snuffy2 commented Jun 8, 2024

Moves entity picture generation out of the event loop.

Fixes #121

@Snuffy2 Snuffy2 force-pushed the Fix-blocking-of-entity-picture-generation branch from 9782f4c to 3b8e72e Compare June 8, 2024 03:48
@Disane87
Copy link
Owner

Disane87 commented Jun 8, 2024

Thank you for these changes @Snuffy2

Could you please push them to dev like stated in the readme? Please make sure to use conventional commits

https://github.com/Disane87/spoolman-homeassistant#contributing

@Snuffy2 Snuffy2 changed the base branch from main to dev June 8, 2024 12:13
@Disane87 Disane87 merged commit 6f54177 into Disane87:dev Jun 9, 2024
@Disane87
Copy link
Owner

Disane87 commented Jun 9, 2024

🎉 This PR is included in version 0.4.4-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Disane87
Copy link
Owner

Disane87 commented Jul 2, 2024

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting with 2024.6 - Detected blocking call to open inside the event loop
2 participants