Update resolved data structure in application command interactions #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azn9
approved these changes
Mar 23, 2024
Azn9
added
field/addition
|
I cannot push to your repo to rebase the branch so I'll close this PR and merge it via #165 |
|
I'm stupid, threads don't exist on 1.6.X so it cannot be merged there... 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification: I think there was a misunderstanding in https://discord.com/developers/docs/interactions/receiving-and-responding#interaction-object-resolved-data-structure.
Those fields in partial channel objects may be included, but they are not mandatory. They do have the same properties as in the channel object description.
This PR also includes the thread related fields, as they are missing.
This PR is required to fix issue #1171 in D4J.