Updates Invite #60
Merged
Updates Invite #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanticc
added
field/addition
quanticc
added
field/type-change
darichey
reviewed
Apr 10, 2021
Comment on lines
+32
to
+35
| /* TODO | ||
| * @JsonProperty("target_application") | ||
| * Possible<?> targetApplication(); | ||
| */ |
There was a problem hiding this comment.
Is this because we don't have any application stuff? Do we need to do anything about that (can be done separately if so)?
There was a problem hiding this comment.
The target_application object returned is a partial application object
There is no example of what it could be or what are the fields and I didn't try myself to see
quanticc
pushed a commit
to Discord4J/Discord4J
that referenced
this pull request
Apr 14, 2021
quanticc
pushed a commit
to Discord4J/Discord4J
that referenced
this pull request
Apr 14, 2021
quanticc
pushed a commit
to Discord4J/Discord4J
that referenced
this pull request
Apr 14, 2021
quanticc
added a commit
to Discord4J/Discord4J
that referenced
this pull request
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification: discord/discord-api-docs#2690