Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/blockbuffer #100

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Patch/blockbuffer #100

merged 4 commits into from
Feb 28, 2024

Conversation

BrandonKoerner
Copy link
Member

  • Finalize implementation of BlockBuffer, which now provides IView
  • Switch Block production logic to use BlockBuffer as an IView provider
  • Switch ValidationCache logic to use BlockBuffer
  • Switch handler's block and transaction-related logic to use BlockBuffer
  • Fix bug where invalid Triptych proofs could be accepted on linux builds
  • Fix bug where orphan chains would miss blocks
  • Fix bug where roots of orphan chains did not match the DataView's current block
  • Fix race condition in ChainDB updates (BlockBuffer)

@BrandonKoerner BrandonKoerner merged commit c7eb5d1 into staging Feb 28, 2024
@BrandonKoerner
Copy link
Member Author

BrandonKoerner commented Feb 28, 2024

Additonal notes:

  • Fixed issue in TransactionConverter where NumPInputs and related fields were not populated
  • Fixed issues in other converters
  • Fixed bug where OrphanBlockException occurring in AcceptOrphans would cause the rest of the orphan chain to be tossed
  • Fixed bug in BlockBuffer where valid blocks during syncing in a chunk were not committed to ChainDB
  • Changed MessageCache's OrphanBlockParents to reference the actual hash of the parent
  • Updated the Default AuthKeys for the next chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant