Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added responsiveness to the existing navbar #135

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ARYPROGRAMMER
Copy link

This PR fixes the Issue #30.

Added responsiveness to the navbar and removed the white screen residue error

Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
Copy link

vercel bot commented Jan 17, 2025

@ARYPROGRAMMER is attempting to deploy a commit to the Dishika's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ARYPROGRAMMER
Copy link
Author

@Dishika18 please review and merge

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
insight-sync ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 0:22am

@Dishika18
Copy link
Owner

@ARYPROGRAMMER The navbar layout has completely changed, and it doesn't look good. Also, the website's responsiveness is not working properly.

Before:
Screenshot 2025-01-17 133221

After:
Screenshot 2025-01-17 133232
Screenshot 2025-01-17 133249

@ARYPROGRAMMER
Copy link
Author

@ARYPROGRAMMER The navbar layout has completely changed, and it doesn't look good. Also, the website's responsiveness is not working properly.

Before: Screenshot 2025-01-17 133221

After: Screenshot 2025-01-17 133232 Screenshot 2025-01-17 133249

Give me Just a few hours, I'll fix this

Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
@ARYPROGRAMMER
Copy link
Author

@Dishika18 check this out, this is much better than prev. version

@Dishika18
Copy link
Owner

@Harshvardhan-91 The navbar now looks fine in desktop mode, but it's still not good in mobile view. Also, the white screen issue is still slightly visible.

mobile view before:
Screenshot 2025-01-18 122931

After:
Screenshot 2025-01-18 122938

white screen issue:
Screenshot 2025-01-18 123117

Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
@Dishika18
Copy link
Owner

@ARYPROGRAMMER The recent changes have made the design less responsive, and the logo color has changed. It was better before.

Screenshot 2025-01-18 175415

@ARYPROGRAMMER
Copy link
Author

@ARYPROGRAMMER The recent changes have made the design less responsive, and the logo color has changed. It was better before.

Screenshot 2025-01-18 175415

yes i know i know that's why i didnt ping you, allow me some time i have to properly give this time now. thanks

@Dishika18
Copy link
Owner

That’s fine, @ARYPROGRAMMER. Take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants