feat(Onboarding): add edit method

[Victorsitou]

Summary

discord/discord-api-docs#6101

blocked by #928

Checklist

• If code changes were made, then they have been tested
  • I have updated the documentation to reflect the changes
  • I have formatted the code properly by running pdm lint
  • I have type-checked the code by running pdm pyright
• This PR fixes an issue
• This PR adds something new (e.g. new method or parameters)
• This PR is a breaking change (e.g. methods or parameters removed/renamed)
• This PR is not a code change (e.g. documentation, README, ...)

[shiftinv]

Any updates on this?

[shiftinv]

Suggested change

	Accesing this during construction will raise an :exc:`ValueError`.
	"""
	if not self._guild or self.id == 0:
	# TODO: better message and error?
	raise ValueError("You cannot access this on construction.")
	Accessing this on manually constructed instances will raise a :exc:`ValueError`.
	"""
	if not self._guild:
	raise ValueError("Roles cannot be resolved on manually constructed instances.")

something like this, maybe?

[Enegg]

If there's a discrepancy between user constructible and api-originating objects, then user constructible shouldn't have that parameter at all

[shiftinv]

@Enegg So what you're proposing is separating this into something like PartialOnboardingPromptOption (user constructible) and OnboardingPromptOption (api model)?

[Enegg]

Mhm
Separate types provide a clear distinction of what a user can and cannot do

[shiftinv]

hmm, yeah. I agree with clear separation being better, however I'm not sure it's worth the effort here... it might be? With the way documentation works, this would mean a bunch of duplication both in the source code and in the built docs, for only a fairly small benefit, though.
The same topic also applies the polls implementation, might revisit this later after giving polls some more thought