-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: escape headers and unordered lists in markdown utils #1058
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replaces #
and -
anywhere in a string, not only at the start of a line
Seems like something that could use a bunch of testing, so moving it to the next version might make sense here.
Sigh, that's fair. Possibly can be part of a bugfix release, like 2.9.1 |
242e5a5
to
cb0085e
Compare
Due to more quirks with the client this entire implementation is wrong. |
Summary
Expanded markdown support in remove markdown and escape markdown methods. This does not currently support ordered lists, unfortunately.
Checklist
pdm lint
pdm pyright