Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape headers and unordered lists in markdown utils #1058

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

onerandomusername
Copy link
Member

Summary

Expanded markdown support in remove markdown and escape markdown methods. This does not currently support ordered lists, unfortunately.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Jun 19, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Jun 19, 2023
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces # and - anywhere in a string, not only at the start of a line

Seems like something that could use a bunch of testing, so moving it to the next version might make sense here.

@onerandomusername
Copy link
Member Author

This replaces # and - anywhere in a string, not only at the start of a line

Seems like something that could use a bunch of testing, so moving it to the next version might make sense here.

Sigh, that's fair. Possibly can be part of a bugfix release, like 2.9.1

@onerandomusername
Copy link
Member Author

Due to more quirks with the client this entire implementation is wrong.

@shiftinv shiftinv added s: planned Issue is planned in the future t: bugfix and removed s: needs review Issue/PR is awaiting reviews labels Dec 26, 2024
@shiftinv shiftinv removed this from the disnake v2.10 milestone Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: planned Issue is planned in the future t: api support Support of Discord API features t: bugfix
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants