Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(member): implement member banners #1204

Merged
merged 9 commits into from
Nov 16, 2024

Conversation

Snipy7374
Copy link
Collaborator

Summary

Note that this is still untested as the feature is not rolled out yet.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Jul 18, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Jul 18, 2024
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than those two comments, looks good to me! seems pretty straightforward.

disnake/member.py Show resolved Hide resolved
disnake/member.py Show resolved Hide resolved
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

disnake/member.py Outdated Show resolved Hide resolved
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
disnake/member.py Show resolved Hide resolved
@Snipy7374
Copy link
Collaborator Author

The "waiting for api docs" label can now be remoed 🙏🏻

@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Nov 16, 2024
@shiftinv
Copy link
Member

As a side note, the Asset._from_* method naming now seems a bit weird overall - guild banners (the ones at the top of the channel list) use _from_banner, while guild member banners (guild-specific profile banners) use _from_guild_banner, which is a bit silly. Doesn't really matter, especially since these are internal methods exclusively.

@shiftinv shiftinv enabled auto-merge (squash) November 16, 2024 16:45
@shiftinv shiftinv merged commit ac5a936 into DisnakeDev:master Nov 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add support for member banners
3 participants