This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
"garyburd" => "gomodule" untangling #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like Sirupsen -> sirupsen, here garyburd -> gomodule. Uses of the old name are giving us headaches elsewhere, it's time to remove them.
I also installed redis and verified that all tests pass.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago, the redis package used by this repository underwent a rename, similar to the infamous Sirupsen => sirupsen name change. That was causing tests in go-lib to fail, as it depends on this repository in its background and indexer packages.
In addition, the comparison benchmarks were run against repositories that were stale and unmaintained by fall of 2018. Invalid import paths were causing tests to fail in go-lib. As the benchmarks were not currently needed, they were removed.
Update readme.