[pull] master from ropensci:master #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=80&v=4){kind=small}
* Replace iris examples with palmerpenguins * Fix duplicate line * Re-generate documentation * Replaces iris with penguin in tests
* Fix bug. If is.null(data_xy): Set data_xy to mean of data_xy_min and data_xy_max. * Add test. Check geom_errorbar is rendered when y aes is not set. * Fix bug. geom_errobar is now rendered with flipped aes. Add test. * Minor fixes. Add explanation and reprex for flipped_aes in geom2trace.GeomErrorbar. Simplify code in make_error. * Update R/layers2traces.R * Add visual test to check that geom_errobar is rendered when y aes is not set. * Add visual test to check that geom_errobar is rendered with flipped aes.
* Fix #1870 by explicitly including milliseconds when converting to JSON * Added visual test for #1870 * Fix POSIXt format for plotly JSON According to plotly documentation (https://plotly.com/chart-studio-help/date-format-and-time-series/): "Chart Studio’s date format is 'yyyy-mm-dd HH:MM:SS.ssssss'.", so time_format in jsonlite::toJSON() changed to match. * Fixing time format in test re: #1871 * Update test image for line-milliseconds.svg
* update to plotly.js v1.57.1 * move hexbin to suggests to avoid CRAN note * validate new baselines
…cks on the figure data is overkill and is dependent on GEOS version
… available Also, prefer jpeg over Cairo since it doesn't really matter what device we use, and it seems Cairo will need to be reinstalled in R 4.1 for it to work
…e docker container installs dependencies at run-time
chschan
added a commit
that referenced
this pull request
Dec 26, 2020
Merge branch 'ropensci-master' # Conflicts: # R/plotly.R # inst/htmlwidgets/lib/plotlyjs/plotly-latest.min.js
chschan
added a commit
that referenced
this pull request
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )