Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more quotes to Highlight (Single,Double) Quotes in Selection? #520

Closed
tangledhelix opened this issue Nov 10, 2024 · 1 comment
Closed
Assignees
Labels
future feature New feature or request, but not core

Comments

@tangledhelix
Copy link
Collaborator

In #42 I added guillemets, etc to the highlighted items, which GG1 didn't handle. Add the same quotes to Highlight Single/Double Quotes in Selection commands. I would probably use different colors to differentiate them (quite probably the color maps from #42 should be re-used). Currently all quotes are highlighted in one color, so even straight and curly quotes aren't differentiated from one another today.

New single quotes:

  • ‹test› SINGLE {LEFT, RIGHT}-POINTING ANGLE QUOTATION MARK
  • ‛test‚ SINGLE {HIGH-REVERSED-9, LOW-9} QUOTATION MARK

New double quotes:

  • «test» {LEFT, RIGHT}-POINTING DOUBLE ANGLE QUOTATION MARK
  • ‟test„ DOUBLE {HIGH-REVERSED-9, LOW-9} QUOTATION MARK

The "9" quotes are not used very commonly, but I think it would be useful to highlight them, and in a different color, since they are hard to distinguish from a normal curly opening quote followed by a comma.

@windymilla I'll handle this one if you want to assign to me.

@windymilla windymilla added the future feature New feature or request, but not core label Nov 11, 2024
@tangledhelix
Copy link
Collaborator Author

After discussion, dropping this idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future feature New feature or request, but not core
Projects
None yet
Development

No branches or pull requests

2 participants