Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight surrounding quotes/brackets #42

Closed
windymilla opened this issue Dec 15, 2023 · 2 comments · Fixed by #519
Closed

Highlight surrounding quotes/brackets #42

windymilla opened this issue Dec 15, 2023 · 2 comments · Fixed by #519
Assignees
@tangledhelix
Labels
core feature Required for basic PPing

Comments

@windymilla
Copy link
Collaborator

In GG1 Search menu
@windymilla windymilla added the core feature Required for basic PPing label Feb 18, 2024
@tangledhelix
Copy link
Collaborator

I'm looking into this.

This was referenced May 27, 2024
Closed
Closed
@tangledhelix tangledhelix mentioned this issue Jul 15, 2024
Closed
@tangledhelix
Copy link
Collaborator

The Perl implementation of this comes from the Perl TK module, it's not our own code. So far I haven't found a similar function in tkinter, so most likely I'll port the Perl code and make it part of the GG2 codebase itself.

See HighlightSinglePairBracketingCursor function defined here (starting on line 432 as of this writing):

https://metacpan.org/release/SREZIC/Tk-804.036/source/Tk/TextEdit.pm

tangledhelix added a commit to tangledhelix/guiguts-py that referenced this issue Nov 7, 2024
@tangledhelix
Class refactor needed to prepare for DistributedProofreaders#42
f3bbb9c 
In order for enum.auto() to work here using StrEnum, the class
can only contain these auto-string variables; the dicts for
color definitions have to be separated.
tangledhelix added a commit to tangledhelix/guiguts-py that referenced this issue Nov 7, 2024
@tangledhelix
Class refactor needed to prepare for DistributedProofreaders#42
7d43c48 
In order for enum.auto() to work here using StrEnum, the class
can only contain these auto-string variables; the dicts for
color definitions have to be separated.
windymilla pushed a commit that referenced this issue Nov 7, 2024
@tangledhelix
Class refactor needed to prepare for #42 (#516)
fcb0503 
In order for enum.auto() to work here using StrEnum, the class
can only contain these auto-string variables; the dicts for
color definitions have to be separated.
This was referenced Nov 9, 2024
Merged
Closed
Closed
tangledhelix added a commit to tangledhelix/guiguts-py that referenced this issue Nov 13, 2024
@tangledhelix
Highlight quote marks & brackets
cb57f7c 
When activated from the Search menu, this mode finds pairs of quote
marks and brackets surrounding the cursor position and highlights them.
Only pairs are highlighted, and only the nearest surrounding pair (of
each type) surrounding the cursor is highlighted.

Also fixes a failing test (on macOS) in pytest.

Fixes DistributedProofreaders#42
tangledhelix added a commit to tangledhelix/guiguts-py that referenced this issue Nov 16, 2024
@tangledhelix
Search menu re-order, re-group
caf7df3 
Relates to DistributedProofreaders#42
windymilla pushed a commit that referenced this issue Nov 16, 2024
@tangledhelix
Search menu re-order, re-group (#529)
de2ce90 
Relates to #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tangledhelix tangledhelix

Labels
core feature Required for basic PPing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Highlight quote marks & brackets tangledhelix/guiguts-py
2 participants
@tangledhelix @windymilla