Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit color scheme from "Highlight Quotes & Brackets" #521

Closed
tangledhelix opened this issue Nov 10, 2024 · 3 comments
Closed

Revisit color scheme from "Highlight Quotes & Brackets" #521

tangledhelix opened this issue Nov 10, 2024 · 3 comments
Assignees
@tangledhelix
Labels
core feature Required for basic PPing

Comments

@tangledhelix
Copy link
Collaborator

Revisit the color scheme in #42:

  • Perhaps similar quotes could be in the same color family (e.g. single / double curly quotes are two distinct greens)
  • Look into colorblindness-friendly color palettes to be more accessible
  • Review colors in all 3 available themes and on all platforms
  • Review any differences in OS-level dark/light mode, if it changes how GG looks in its different themes

@windymilla I'll take this one too
@tangledhelix tangledhelix mentioned this issue Nov 10, 2024
Merged
@tangledhelix
Copy link
Collaborator Author

Some resources for later review:

@windymilla
Copy link
Collaborator

Just linking this to #353

@windymilla windymilla added the core feature Required for basic PPing label Nov 11, 2024
@tangledhelix tangledhelix mentioned this issue Nov 18, 2024
Closed
@tangledhelix
Copy link
Collaborator Author

Closing as this is already linked...

@tangledhelix tangledhelix mentioned this issue Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tangledhelix tangledhelix

Labels
core feature Required for basic PPing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tangledhelix @windymilla