Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor _highlight_configure_tag to use is_dark_theme #532

Closed
tangledhelix opened this issue Nov 17, 2024 · 1 comment · Fixed by #533
Closed

Refactor _highlight_configure_tag to use is_dark_theme #532

tangledhelix opened this issue Nov 17, 2024 · 1 comment · Fixed by #533
Assignees
@tangledhelix
Labels
code improvement Improve maintainability, consistency, etc

Comments

@tangledhelix
Copy link
Collaborator

As discussed in #525, consider updating _highlight_configure_tag to use is_dark_theme to auto-detect light/dark when calculating what colors to apply.

Potentially this would simplify a few things, including perhaps not needing to define a "Default" value in the color maps at all, and using only "Light" and "Dark".
@tangledhelix tangledhelix added the code improvement Improve maintainability, consistency, etc label Nov 17, 2024
@tangledhelix tangledhelix self-assigned this Nov 17, 2024
@tangledhelix tangledhelix mentioned this issue Nov 17, 2024
Merged
@windymilla
Copy link
Collaborator

Yes - I think this is a good idea

tangledhelix added a commit to tangledhelix/guiguts-py that referenced this issue Nov 18, 2024
@tangledhelix
Dynamically detect dark/light mode for "Default"
b10d53c 
Fixes DistributedProofreaders#532
@tangledhelix tangledhelix mentioned this issue Nov 18, 2024
Merged
tangledhelix added a commit to tangledhelix/guiguts-py that referenced this issue Nov 19, 2024
@tangledhelix
Dynamically detect dark/light mode for "Default"
4fb2ff9 
Fixes DistributedProofreaders#532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tangledhelix tangledhelix

Labels
code improvement Improve maintainability, consistency, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamically detect dark/light mode for "Default" theme tangledhelix/guiguts-py
2 participants
@tangledhelix @windymilla