Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mypy stricter #540

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

windymilla
Copy link
Collaborator

Add --disallow-untyped-defs option to mypy run.

Without this, it doesn't catch
def highlight_aligncol_in_viewport(viewport: Text):
which doesn't have a return type declared.

Copy link
Collaborator

@tangledhelix tangledhelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I had believed this check was already in place! I didn't test it myself (Github Actions will do that for us).

@windymilla
Copy link
Collaborator Author

Thanks @tangledhelix - yes, I was surprised when I ran my "check everything" script (where I do have that flag set) and it reported an error in master. I didn't add it originally to Github Actions because I was unsure how much of a pain it would be, and so just left the settings at the defaults.

@windymilla windymilla merged commit 064b9f4 into DistributedProofreaders:master Nov 23, 2024
1 check passed
@windymilla windymilla deleted the mypy-stricter branch November 23, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants