Catch edge-case exception in macOS clipboard #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If macOS clipboard contains non-text (e.g., an image) and user triggers smart_cut or smart_copy functions, TclError is thrown when TCL code "clipboard get" is run. Catch error and return from method if this happens. Fixes DistributedProofreaders#548
|
See #548 for how to reproduce the problem; can test on master branch and on this branch to compare whether you get an exception under the same conditions. |
srjfoo
approved these changes
Nov 28, 2024
windymilla
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If macOS clipboard contains non-text (e.g., an image) and user triggers smart_cut or smart_copy functions, TclError is thrown when TCL code "clipboard get" is run. Catch error and return from method if this happens.
Fixes #548