pphtml no longer finds .br when unused

[btaylor289]

Running version 1.6.0 of Guiguts.

I click on HTML/PPhtml and view the report of "CSS possibly not used:" br no longer shows up even when unused. I have
run across this three times now after upgrading to the latest version of Guiguts.

The CSS code in my html file is: .br {border-right: 2px solid;}

The online version of PPhtml does list br as defined but not used

I've attached a screenshot of both the online and Guiguts outputs showing the difference.
Thanks
Bob

[windymilla]

The explanation is that br is the name of an HTML element. While this is legal to also use a CSS class name, the changes to the code in pphtml (to avoid previous false positives) stores the elements and class names used in the same structure. Therefore since your file contains the element <br>, pphtml mistakenly counts that as using class="br".
I'll have a look at the code to see if it can be rewritten to properly distinguish between elements and class names.

[windymilla]

@btaylor289 - please could you copy this version of pphtml into your lib/ppvchecks folder under your Guiguts release, and see if it works as you expect. Thanks

[btaylor289]

Hi Nigel,

Yes, this updated pphtml did find the unused .br in my CSS. One change is the entire list is in reversed order from what I'm used to. I'm not complaining - I like it in this order.

Thanks
Bob

[windymilla]

Oh yes, forgot to mention that I decided to reverse the list while I was fixing the bug

[windymilla]

Updated version in case you want it, @btaylor289. Previous version gave spurious report about x-ebookmaker classes.

[btaylor289]

Got it and it seemed to work just fine. Thank you Nigel. Bob

…

On Mon, Aug 28, 2023 at 2:30 PM Nigel ***@***.***> wrote: Updated version <https://www.dropbox.com/scl/fi/qjtc4jb650uzphmzhr7sm/pphtml.pl?rlkey=pysr9xghdjdhx83fy206ww6b1&dl=0> in case you want it, @btaylor289 <https://github.com/btaylor289>. Previous version gave spurious report about x-ebookmaker classes. — Reply to this email directly, view it on GitHub <#1240 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A45B5GPBEKP7KDNOFDOMYBDXXTWWDANCNFSM6AAAAAA373K6KU> . You are receiving this because you were mentioned.Message ID: ***@***.***>