Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert fractions converts negative fractions incorrectly. #1295

Closed
windymilla opened this issue May 27, 2024 · 0 comments · Fixed by #1299
Closed

Convert fractions converts negative fractions incorrectly. #1295

windymilla opened this issue May 27, 2024 · 0 comments · Fixed by #1299
Labels
bug Something isn't working

Comments

@windymilla
Copy link
Collaborator

The fraction -1/2 gets converted to ½

This is because the - is captured by the regex, presumably to catch 1-1/2.

It should only remove the hyphen if the character before the hyphen is a digit.
@windymilla windymilla added the bug Something isn't working label May 27, 2024
@windymilla windymilla linked a pull request Jun 6, 2024 that will close this issue
Convert negative fractions properly #1299
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert negative fractions properly windymilla/guiguts
1 participant
@windymilla