Convert negative fractions properly #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously converted `-1/2` to `½` due to error trying to handle `3-1/2`. Bug noticed during GG2 development.
|
Granted, it's kind of a silly thing to do, but, if I try to convert a fraction like
GG2 does nothing. I'm wondering if that deserves a user-readable message, something like "Attempt to convert fraction to Unicode failed: no equivalent available" in both places? I'm also okay with just leaving it the way GG2 handles it, and ignoring it, with a warning in the manual. |
srjfoo
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously converted
-1/2to½due to error trying to handle3-1/2.Bug noticed during GG2 development.