Handle coincident page marks better #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ReplaceSelectionsWith` function handles keeping page marks in approximately the same location when a Search/Replace operation spans a page boundary (by maintaining the relative proportion of text each side of the page boundary). This did not cope correctly when there were two or more page marks at the same location (i.e. blank pages). The page marks could get reversed, so that 015 came before 014, for example (although still both at the same location). Avoiding changing the mark gravity (whether the mark goes left or right of text inserted at the mark) fixes this for marks within the S/R region. Temporarily setting "right" gravity for page marks that immediately follow the S/R region keeps those page marks correct.
|
Testing notes: Charlie's example in the linked issue shows the problem - you can right-click the Img label to show/hide where the page marks are. Around line 420 the page marks 014 and 015 are in the correct order, but without this PR, HTML->Generator, Autogenerate causes those to be swapped. They should now remain in the correct order. The initial attempt at fixing this broke S/R across page boundaries. You can test this out by doing regex replaces, like replacing |
srjfoo
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ReplaceSelectionsWithfunction handles keeping page marks in approximately the same location when a Search/Replace operation spans a page boundary (by maintaining the relative proportion of text each side of the page boundary).This did not cope correctly when there were two or more page marks at the same location (i.e. blank pages). The page marks could get reversed, so that 015 came before 014, for example (although still both at the same location).
Avoiding changing the mark gravity (whether the mark goes left or right of text inserted at the mark) fixes this for marks within the S/R region. Temporarily setting "right" gravity for page marks that immediately follow the S/R region keeps those page marks correct.