Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip bad words in Spell Query #1281

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

windymilla
Copy link
Collaborator

The SQ threshold stops words that appear lots of times from being reported as spelling errors. That check shouldn't apply to bad words, which should always be reported.

The SQ threshold stops words that appear lots of times from
being reported as spelling errors. That check shouldn't apply
to bad words, which should always be reported.
@windymilla windymilla requested a review from srjfoo November 24, 2023 19:34
@windymilla
Copy link
Collaborator Author

Testing notes:
Create good_words.txt and bad_words.txt.
Put any word you like in the bad words file, e.g. xyz
Then open a text file in GG and add xyz in a few times (e.g. 3 times)
Also add 3 times another misspelling that is not in the bad words list, e.g. speelcheck
Run Tools->Spell Query
At the top of the dialog is a Threshold. When that is less than 3, and Spell Query is run, speelcheck should not appear, but xyz should (because it is bad). When the threshold is 3 or more, both speelcheck and xyz should appear.

@windymilla windymilla merged commit 529d91e into DistributedProofreaders:master Nov 28, 2023
1 check passed
@windymilla windymilla deleted the badwords branch November 28, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants