Improve quote/bracket highlighting #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was necessary to change the text between two quotes or brackets for them to be highlighted by the Preferences->Enable Quotes Highlighting operation. There was also no easy way to remove the highlighting apart from moving the cursor somewhere in the text where it wasn't between quotes or brackets and modifying the text again. The code used a built-in feature of the Text widget. Now, combine the built-in Text widget feature with the control method used for scanno highlighting, i.e. set a repeating callback to the highlight routine. Also, adjust the default behaviour to make it check for matching quotes across multiple lines as it does for brackets, instead of single line as before. Also add curly quote support. Fixes DistributedProofreaders#780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was necessary to change the text between two quotes or brackets
for them to be highlighted by the Preferences->Enable Quotes Highlighting
operation. There was also no easy way to remove the highlighting apart from
moving the cursor somewhere in the text where it wasn't between quotes or
brackets and modifying the text again. The code used a built-in feature of
the Text widget.
Now, combine the built-in Text widget feature with the control method used
for scanno highlighting, i.e. set a repeating callback to the highlight routine.
Also, adjust the default behaviour to make it check for matching quotes across
multiple lines as it does for brackets, instead of single line as before.
Also add curly quote support.
Fixes #780