Add missing <algorithm> include #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesgarland
approved these changes
Feb 5, 2022
sparist
pushed a commit
that referenced
this pull request
Oct 18, 2023
There are two problems with multiplanar textures in the OpenGL backend. 1) When the the multiplanar external texture transform runs, it splits a texture_external variable into two texture_2d variables. The Resolver then creates new texture/sampler pairs for the samplers with which the plane1 texture is used, and new binding points for those that bubble up to the global level. Since Dawn collects sampler/texture pairs from the Inspector before the transforms run, it doesn't know about these extra pairs, doesn't name them and doesn't bind anything to them. 2) The multiplanar transform also inserts calls to textureDimensions(), a texture-only builtin that doesn't require a sampler. In the CombineSamplers transform, since OpenGLES doesn't have the concept of a texture-only sampler2d, this necessitates the creation of new binding points for the texture with a "placeholder" sampler, which Dawn also doesn't know about, so it doesn't name them or bind anything to them. Fix #1 is on the Dawn side: when iterating over external texture bindings, create a map from plane0 texture -> plane1 texture. When iterating over the sampler/texture uses that the Tint inspector has discovered, if the texture is an external texture, add a new pair with the same sampler and the plane1 texture. Fix for #2 is on the Tint side: if a function contains both a texture-only reference and a texture/sampler reference to the same texture, use the latter and remove the former. Texture-only builtins won't use the sampler anyway. This is essentially an optimization, but it's one we know will run on the functions generated by the multiplanar transform, since it always calls textureDimensions() in a function also containing the textureSample() call on the same texture. Change-Id: I531ab09acdc47b435d72033aabd9eefa57f8f6e3 Bug: tint:1774 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/152660 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCP-2603