Skip to content

Commit

Permalink
node-api: treat V8 platform symbols same as base
Browse files Browse the repository at this point in the history
Export V8 platform symbols in the Node shared library build,
in the same way as with V8 base, to allow linking on Windows.

PR-URL: nodejs#49596
  • Loading branch information
sparist committed Sep 13, 2023
1 parent 98d83ce commit fde500e
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -1339,10 +1339,7 @@
'<(V8_ROOT)/src/libplatform/worker-thread.h',
],
'conditions': [
['component=="shared_library"', {
'direct_dependent_settings': {
'defines': ['USING_V8_PLATFORM_SHARED'],
},
['is_component_build', {
'defines': ['BUILDING_V8_PLATFORM_SHARED'],
}],
['v8_use_perfetto==1', {
Expand Down

0 comments on commit fde500e

Please sign in to comment.