-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Agent.build() and return app
for use in serverless environments
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jzanecook
previously approved these changes
Apr 1, 2024
Hey @nalbion I'm trying to run this and I'm running into the following error using the minimal example:
Do you think you could merge in some of the new changes to the js sdk and verify that this is an issue on your side as well? Nevermind, I didn't use a local import for the minimal example. This is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Small refactor to
createApi()
to returnapp
and optionally not start listening. This allows the JavaScript library to be used from serverless functions in AWS, Google etc.Checklist
Please review and check the following items to ensure your pull request can be processed smoothly:
[*] My code adheres to the project's coding standards and style guidelines.
[*] I have tested my changes thoroughly, including unit tests where applicable.
[*] I have updated the documentation to reflect any changes made in this pull request.
[*] My branch is up-to-date with the latest changes from the main branch.
I have received code review feedback and addressed any comments or concerns.