Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(default-theme): hide language switcher if only one language #1211

Merged
merged 2 commits into from
Nov 17, 2020
Merged

fix(default-theme): hide language switcher if only one language #1211

merged 2 commits into from
Nov 17, 2020

Conversation

jnuricumbo
Copy link
Contributor

closes #1206

Changes

Language switcher only visible if more than one language exist

Checklist

@vercel
Copy link

vercel bot commented Oct 29, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/ixpkjdc1o
✅ Preview: https://shopware-pwa-d-git-fix-default-themehide-language-switch-3fbafd.shopware-pwa.vercel.app

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to preview October 29, 2020 22:36 Inactive
@jnuricumbo jnuricumbo changed the base branch from release/v0.5 to master October 29, 2020 22:46
@jnuricumbo jnuricumbo mentioned this pull request Oct 29, 2020
Closed
mkucmus
mkucmus approved these changes Nov 16, 2020
View reviewed changes
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good idea!

@mkucmus
Copy link
Collaborator

mkucmus commented Nov 16, 2020

@jnuricumbo please resolve the conflicts with master and it's ready!

@jnuricumbo jnuricumbo force-pushed the fix/default-theme/hide-language-switcher-when-only-one-language-available-#1206 branch from 4b82f6f to ffc9bd4 Compare November 17, 2020 20:28
@vercel vercel bot temporarily deployed to preview November 17, 2020 20:28 Inactive
@jnuricumbo jnuricumbo force-pushed the fix/default-theme/hide-language-switcher-when-only-one-language-available-#1206 branch from ffc9bd4 to edcab6a Compare November 17, 2020 20:41
@vercel vercel bot temporarily deployed to preview November 17, 2020 20:41 Inactive
@jnuricumbo jnuricumbo changed the title fix(default-theme): hide language switcher when only one language ava… fix(default-theme): hide language switcher if only one language Nov 17, 2020
@jnuricumbo
Copy link
Contributor Author

@mkucmus thank you for approving this PR. The conflicts are resolved, but can you give me please a hit, what is wrong with the PR tittle? I tried to fix it without success 😞

@vercel vercel bot temporarily deployed to preview November 17, 2020 20:53 Inactive
@mkucmus
Copy link
Collaborator

mkucmus commented Nov 17, 2020

@mkucmus thank you for approving this PR. The conflicts are resolved, but can you give me please a hit, what is wrong with the PR tittle? I tried to fix it without success

I think you did everything right, but there are some limitations of the gh action for forked PRs :/ It's worth checking it out

@mkucmus mkucmus merged commit 8727821 into vuestorefront:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkucmus mkucmus mkucmus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Language selector on top bar is not correctly displayed.
3 participants
@jnuricumbo @CLAassistant @mkucmus