Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(product): handle variants change. #214

Merged
merged 9 commits into from
Dec 16, 2019
Merged

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Dec 13, 2019

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 16, 2019

Deploy preview for website ready!

Built with commit 856adb7

https://shopware-pwa-8xtk2n9pg.now.sh

@patzick
Copy link
Collaborator

patzick commented Dec 16, 2019

There is a bug in SfSelect in UI, but not related to this task, shows empty selects when setting after the component is mounted
image

@patzick patzick marked this pull request as ready for review December 16, 2019 14:15
Copy link
Collaborator Author

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 can't approve my own, but it's totally your PR ;)

@patzick
Copy link
Collaborator

patzick commented Dec 16, 2019

Related follow-up Issue -> vuestorefront/storefront-ui#561

@patzick
Copy link
Collaborator

patzick commented Dec 16, 2019

and closes #14, #210

@patzick patzick merged commit 1bbde20 into master Dec 16, 2019
@patzick patzick deleted the feat/14-variant-change branch December 16, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants