Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use navigation urls taken from API #366

Merged
merged 5 commits into from
Feb 6, 2020
Merged

feat: use navigation urls taken from API #366

merged 5 commits into from
Feb 6, 2020

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Feb 6, 2020

closes #365

keep in mind: technical URLs will be replaced with the pretty URLs once it's handled on API side.

Changes

  • new helper to convert navigation from SW API
  • add recursion to navi children elements
  • not use the slugify anymore: removed from packages
  • navigation converter moved from composable "useNavigation"
  • some tiny refactor changes

Screenshots of visual changes

Checklist

  • I followed code and contributing guidelines
  • I wrote all needed tests

@mkucmus mkucmus requested a review from krskibin February 6, 2020 14:47
krskibin
krskibin approved these changes Feb 6, 2020
View reviewed changes
Copy link
Collaborator

@krskibin krskibin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👌
Just remember to run yarn build to pass all checks before merging.

@github-actions
Copy link

github-actions bot commented Feb 6, 2020

Deploy preview for website ready!

Built with commit 1fdca82

https://shopware-pwa-gy8zmrwx4.now.sh

@mkucmus mkucmus merged commit 4d7f400 into master Feb 6, 2020
@mkucmus mkucmus deleted the feat/use-pretty-urls-in-navigation branch February 6, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krskibin krskibin krskibin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Header link to categories list use wrong url (slug generation problem)
2 participants
@mkucmus @krskibin