Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): check for changes in public api on CI #496

Merged
merged 9 commits into from
Mar 18, 2020

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Mar 16, 2020

We didn't detect public API change in #488 , this PR should first not pass CI, and pass it after running yarn build locally

@patzick patzick requested a review from mkucmus March 16, 2020 13:53
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@patzick patzick merged commit 8b91b59 into master Mar 18, 2020
@patzick patzick deleted the fix/check-for-breaking-changes-during-build branch March 18, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants