fix(workflow): check for changes in public api on CI (#496)

vuestorefront · Mar 18, 2020 · 8b91b59 · 8b91b59
1 parent eb235c9
commit 8b91b59
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 19 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -1,7 +1,7 @@
 version: 2.1
 orbs:
  coveralls: coveralls/coveralls@1.0.4
- win: circleci/windows@2.2.0
+ # win: circleci/windows@2.2.0
 
 jobs:
  build:
@@ -23,23 +23,23 @@ jobs:
  name: test
  command: yarn test:coverage --w 2
  - coveralls/upload
- test:
- executor: win/default
- working_directory: ~/shopware-pwa
- steps:
- - checkout
- - restore_cache:
- key: dependency-cache-{{ checksum "yarn.lock" }}
- - run:
- name: install dependencies
- command: yarn --frozen-lockfile
- - run:
- name: test
- command: yarn test --w 2
+ # test:
+ #  executor: win/default
+ #  working_directory: ~/shopware-pwa
+ #  steps:
+ #  - checkout
+ #  - restore_cache:
+ #  key: dependency-cache-{{ checksum "yarn.lock" }}
+ #  - run:
+ #  name: install dependencies
+ #  command: yarn --frozen-lockfile
+ #  - run:
+ #  name: test
+ #  command: yarn test --w 2
 
 workflows:
  version: 2
  build-test:
  jobs:
  - build
- - test
+ # - test
diff --git a/api/composables.api.md b/api/composables.api.md
@@ -104,6 +104,19 @@ export interface UseProductListing {
 // @alpha (undocumented)
 export const useProductListing: (initialProducts?: Product[]) => UseProductListing;
 
+// @alpha (undocumented)
+export interface UseProductSearch {
+ // (undocumented)
+ [x: string]: any;
+ // (undocumented)
+ error: Ref<any>;
+ // (undocumented)
+ loading: Ref<boolean>;
+}
+
+// @alpha (undocumented)
+export const useProductSearch: () => UseProductSearch;
+
 // @alpha (undocumented)
 export interface UseSalutations {
  // (undocumented)

diff --git a/api/shopware-6-client.api.md b/api/shopware-6-client.api.md
@@ -240,6 +240,8 @@ export interface ShopwareParams {
  page?: number;
  // (undocumented)
  sort?: string;
+ // (undocumented)
+ term?: string;
 }
 
 // @alpha

diff --git a/packages/cli/src/extensions/nuxt-extension.ts b/packages/cli/src/extensions/nuxt-extension.ts
@@ -23,6 +23,7 @@ module.exports = (toolbox: GluegunToolbox) => {
  author: "Vue Storefront",
  pm: "yarn",
  ui: "none",
+ language: "js",
  server: "none",
  features: ["axios", "pwa"],
  linter: ["prettier", "lintStaged"],

diff --git a/packages/nuxt-module/src/index.ts b/packages/nuxt-module/src/index.ts
@@ -1,11 +1,13 @@
 import { Module } from "@nuxt/types";
-import * as Interfaces from "./interfaces";
+/* istanbul ignore next */
+import "./interfaces";
+import { NuxtModuleOptions } from "./interfaces";
 /* istanbul ignore next */
 import { runModule } from "./module";
 
 /* istanbul ignore next */
 const ShopwarePWAModule: Module<{}> = function(moduleOptions: {}) {
- const moduleObject: Interfaces.NuxtModuleOptions = this as any;
+ const moduleObject: NuxtModuleOptions = this as any;
  runModule(moduleObject, moduleOptions);
 };
 

diff --git a/scripts/build.js b/scripts/build.js
@@ -32,10 +32,10 @@ const formats = args.formats || args.f;
 const devOnly = args.devOnly || args.d;
 const prodOnly = !devOnly && (args.prodOnly || args.p);
 const isRelease = args.release;
-const buildTypes = args.t || args.types || isRelease;
+const isCIRun = !!args.ci;
+const buildTypes = true; // args.t || args.types || isRelease || isCIRun; -> for now build always with types
 const buildAllMatching = args.all || args.a;
 const lean = args.lean || args.l;
-const isCIRun = !!args.ci;
 const commit = execa.sync("git", ["rev-parse", "HEAD"]).stdout.slice(0, 7);
 
 run();