Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/426 pictures are not shown in the right places #573

Merged
merged 35 commits into from
Apr 29, 2020

Conversation

Michal-Dziedzinski
Copy link
Collaborator

Changes

closes #426

New components were created: SwCenterText, SwImaggeBubbleRow, SwImageFourColumn, SwImageHighlightRow, SwImageSimpleGrid, SwImageThreeColumn, SwImageThreeCover, SwImageTwoColumn

New components:
image

Checklist

@github-actions
Copy link

github-actions bot commented Apr 2, 2020

💙 shopware-pwa successfully deployed at https://50d9f0731621791898b5339e4e3836bf3f9b705e.shopware-pwa.preview.storefrontcloud.io

Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size of pictures in one block is not correct, e.g.
CMScomponents1
There is too big space between some blocks, e.g.
Cmscomponents2

'Two columns, full-sized image & text' from block category 'image & text' is not displayed correctly e.g.
on our page looks as below:
CMScomponents3

should look as below:
CMScomponents4

Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Two columns, boxed image & text' from block category 'image & text' is not displayed correctly
on our page looks as below:
CMS2columnsboxed
Should look like in the layout from Shopware:
CMS2columnsBoxedShop

Image grid on our page:
CMSimageGrid

Should look like in the layout from Shopware:
CMSimageGridShop

'Three columns, full-sized' and 'Three columns, boxed' on our page looks as below:
Cms3columns

Should look like in the layout from Shopware:
CMS3columnsShopware

Three columns, boxed & background on our page:
CMS3imagesBackground
Should look like in the layout from Shopware:
CMS3imagesBackgroundShop

Pictures on the website should look like in the 'Layout assignment' from Shopware.

@vercel vercel bot temporarily deployed to preview April 29, 2020 07:22 Inactive
@vercel
Copy link

vercel bot commented Apr 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/5defmhhxy
✅ Preview: https://shopware-pwa-do-git-fix-426-pictures-are-not-shown-in-th-e1a268.shopware-pwa.now.sh

@vercel vercel bot temporarily deployed to preview April 29, 2020 07:39 Inactive
@vercel vercel bot temporarily deployed to preview April 29, 2020 12:21 Inactive
@vercel vercel bot temporarily deployed to preview April 29, 2020 15:23 Inactive
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, small adjustments needed

packages/cli/src/templates/shopware-pwa.config.js Outdated Show resolved Hide resolved
packages/default-theme/cms/blocks/CmsBlockCenterText.vue Outdated Show resolved Hide resolved
packages/helpers/src/error/index.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to preview April 29, 2020 15:40 Inactive
@patzick patzick merged commit 9382384 into master Apr 29, 2020
@patzick patzick deleted the fix/426-pictures-are-not-shown-in-the-right-places branch April 29, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]CMS components - Block 'Images' - the pictures are not shown in the right places
3 participants