Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update french wording #8

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Update french wording #8

wants to merge 22 commits into from

Conversation

claireduf
Copy link

Hi
thanks a lot for this useful app!
Some sentences in french were wrong or could be improved, so i provide you a better wording file for french (but it was great already)
if you have any question about what i changed, please ask

Cristi Libotean added 20 commits March 4, 2018 11:08
When initially importing contacts you could end up with duplicated accounts if you had more than one google account you were importing from.
Added ability to show the age the person is turning to (or has turned to) this year.
…erson.

Instead of being able to only add a single extra notification (either 1 day, 2 days, 3 days, 1 week or 2 weeks beforehand) you can add any/all of these.
…r each person for each anniversary. Instead a single, recurring alarm is created that checks for all anniversaries that we need to notify for.

Added library joda-time to help with date handling, date manipulations and fix problems with inconsistencies between days to birthday, days from birth and other problems.
Added notification colors for birthdays that are near.
Added colors for All Fragment page for birthdays that are near.
Made sure notifications are sent in order.
WIP: Attempt to make ads work again.
Allow user to edit anniversary type label.
Clicking on picture or date of birth will bring up contact details window.
@eblis
Copy link

eblis commented Nov 27, 2018

Hi,

I've submitted some pull requests as well, but he doesn't seem to be very active recently.
So I've decided to clone his project and add a few changes of my own, if you want you can check it out here, also available in the play store under WhenWasIt name.
If you want you can submit the pull request to my project as well, I'll try to update as soon as I can.

@MarionMoseby
Copy link

Hey @eblis is WhenWasIt still active? If u remove proprietary ad libraries we might get it to be included on f-droid, a repository for foss and privacy friendly apps. Are u interested in the task?

@eblis
Copy link

eblis commented Dec 6, 2019

Hey

Yes, it's still active. Do you mean remove all ads altogether or just some particular ad libraries ?
The app has a setting to disable all ads, would that suffice ?

@MarionMoseby
Copy link

MarionMoseby commented Dec 6, 2019 via email

@eblis
Copy link

eblis commented Dec 6, 2019

The ad library is AdMob, but the library doesn't have access to the birthdays information.
The problem would be if the app itself were to send the data over the internet, but it doesn't do that.

@IzzySoft
Copy link

IzzySoft commented Dec 6, 2019

@MarionMoseby thanks for the ping (but please sum up what question you want me to answer; I lack the time reading "all the stuff"). As pointed out: apps dealing with PII must not have any trackers/adlibs to be included with my repo, especially no proprietary ones (like AdMob). You can never tell for sure what data those collect.

@eblis Afraid you are wrong: as those modules are part of your app, they have access to everything your app can access. I once wrote an article on that topic, please see What’s it all about those modules apps contain? for details (link goes directly to the corresponding section of the article). Essential quote:

The researchers found that the root cause of the privacy leakage is the lack of isolation between the ads and mobile apps. Adopting HTTPS wouldn’t do anything to protect the ad traffic.

@eblis
Copy link

eblis commented Dec 7, 2019

Hmm, that's good to know, thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants