Add support for -preview=in
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9il
reviewed
Mar 4, 2023
source/cblas/cblas.di
Outdated
| @@ -139,333 +139,333 @@ void cblas_xerbla(blasint p, char *rout, char *form, ...); | |||
| pure: | |||
|
|
|||
| /// | |||
| float cblas_sdsdot(in blasint n, in float alpha, in float *x, in blasint incx, in float *y, in blasint incy); | |||
| float cblas_sdsdot(blasint n, float alpha, float *x, blasint incx, float *y, blasint incy); | |||
There was a problem hiding this comment.
in everywhere in mir and in colas means scope const, can't be replaced with anything else
There was a problem hiding this comment.
in doesn't make sense for value types, but important for pointers and ref values.
|
ping @Geod24 |
|
Fixed |
|
|
|
I don't follow. What's the issue ? |
|
The PR breaks the API. |
9il
reviewed
Mar 7, 2023
source/cblas/cblas.di
Outdated
| /// | ||
| void cblas_zdotu_sub(in blasint n, in _cdouble *x, in blasint incx, in _cdouble *y, in blasint incy, _cdouble *ret); | ||
| void cblas_zdotu_sub(blasint n, _cdouble *x, blasint incx, _cdouble *y, blasint incy, _cdouble *ret); |
There was a problem hiding this comment.
_cdouble *x become mutable. It should be scope const _cdouble *x
9il
reviewed
Mar 7, 2023
source/cblas/cblas.di
Outdated
| /// | ||
| void cblas_zaxpy(in blasint n, in ref _cdouble alpha, in _cdouble *x, in blasint incx, _cdouble *y, in blasint incy); | ||
| void cblas_zaxpy(blasint n, scope const _cdouble* alpha, _cdouble *x, blasint incx, _cdouble *y, blasint incy); |
|
@9il : Can you re-review ? Reverted the |
|
Thanks! Can you make a release too, preferably a patch one since the API hasn't changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bunch of sed, nothing crazy.