Enable blacklisting of optimizations #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitrySoshnikov
approved these changes
Dec 3, 2019
| @@ -123,8 +123,8 @@ const regexpTree = { | |||
| * | |||
| * @return TransformResult object | |||
| */ | |||
| optimize(regexp, whitelist) { | |||
| return optimizer.optimize(regexp, whitelist); | |||
| optimize(regexp, whitelist, {blacklist} = {}) { | |||
There was a problem hiding this comment.
OK, so it's not a breaking change, and existing code which pass just the whitelist will continue to work 👍 Later we can add a deprecation notice, and eventually migrate to the single param with {whitelist, blacklist}.
|
|
||
| expect( | ||
| optimizer | ||
| .optimize(original, {blacklist: ['charClassClassrangesMerge']}) |
There was a problem hiding this comment.
The blacklist is fine, although it disables the full transform. I think eventually we should also have options property, which would allow more granular configuring. Something like:
{
whitelist: ['charClassClassrangesMerge'],
options: {
charClassClassrangesMerge: {
preserveCharOrder: true,
}
}
}
|
Thanks! Merging this one, and if you'd like also to add support for per-transform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to disable some optimizations, as requested in eg. #199. Also adds some specific tests for one of the feature that's highlighted in #199 and is a partial fix for that issue.