Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90
This PR
FieldDefinition
cop. If there are MFD, the resolver method is added after the last field definition.So,
RuboCop::GraphQL::Field.new
now takes in the parent node if field def has a body. Associated changes are made.There is one odd scenario as described in the example below
Running
GraphQL/FieldDefinitions
would add thefirst_name
resolver method after the last field definition.Then running MFD would lead to
So it's preferable to run
GraphQL/MultipleFieldDefinitions
beforeGraphQL/FieldDefinitions
. I did not think too much of it since running rubocop a second time would fix this.