Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade React Native to 0.26 #1027

Merged
merged 3 commits into from
May 24, 2016
Merged

Upgrade React Native to 0.26 #1027

merged 3 commits into from
May 24, 2016

Conversation

aaronschachter
Copy link
Contributor

@aaronschachter aaronschachter commented May 23, 2016 •
edited
Loading

Closes #1026. They're not kidding about those breaking changes!

Starting 0.26:

React API must be now required from react package

@aaronschachter
Copy link
Contributor Author

Fixes #1026 (comment) thanks to facebook/react-native#7697 (comment)

@lkpttn To run the build, you'll need to update your local setup via npm update && pod install

aaronschachter
aaronschachter reviewed May 24, 2016
View reviewed changes
ReactComponents/CauseListView.js
AppRegistry,
ActivityIndicatorIOS,
ListView,
Component,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not certain yet but I suspect we don't need this Component at all...

@aaronschachter
Copy link
Contributor Author

Testing UserView and get a new warning for Profiles with an empty section:

May 24 08:22:17 DoSomething[3496] : Warning: In next release empty section headers will be rendered. In this release you can use 'enableEmptySections' flag to render empty section headers.

@aaronschachter aaronschachter merged commit ef68c40 into develop May 24, 2016
@aaronschachter aaronschachter deleted the issue-1026 branch May 24, 2016 15:29
@aaronschachter aaronschachter mentioned this pull request May 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aaronschachter