Cache helper test + eslint update #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## cleanup/cache #1025 +/- ##
=================================================
+ Coverage 61.25% 61.45% +0.19%
=================================================
Files 66 66
Lines 1017 1017
=================================================
+ Hits 623 625 +2
+ Misses 394 392 -2
Continue to review full report at Codecov.
|
rapala61
approved these changes
Mar 30, 2018
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
| result.should.deep.equal(campaign); | ||
| }); | ||
|
|
||
| test('campaigns.get should return falsy when cache undefined', async (t) => { |
There was a problem hiding this comment.
Thanks for the descriptive tests 👌
| .then(entries => resolve(underscore.first(entries.items))) | ||
| .catch(error => reject(exports.contentfulError(error))); | ||
| .then(entries => resolve(underscore.first(entries.items))) | ||
| .catch(error => reject(exports.contentfulError(error))); |
There was a problem hiding this comment.
Indentation looks better, and probably makes the linter happy as well 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds a test for the cache helper in #1024, which is essentially a copy/paste job from Conversations.
Our linter wasn't happy with the use of
rewire, complaining about aTypeError: Assignment to constant variable.. Updating our lint config to match Conversations made it happy, and required some cleanup in other files.How should this be reviewed?
npm run all-testsAny background context you want to provide?
Once #1024 is merged, I'll edit this PR to merge into
masterinstead ofcleanup/cache.