Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure_flattened does not handle responses that include "errors" but not "data" and "includes" #627

Closed
SamHames opened this issue Apr 20, 2022 · 1 comment · Fixed by #632
Closed

ensure_flattened does not handle responses that include "errors" but not "data" and "includes" #627

SamHames opened this issue Apr 20, 2022 · 1 comment · Fixed by #632
Assignees
@edsu
Labels
bug

Comments

@SamHames
Copy link
Contributor

For example in #626, if you lookup an account that doesn't exist anymore, you will get a response that only has an error key, which is currently passed through as is because it checks for "data" and "includes" keys only. I think the correct behaviour in this key is an empty response, as an API response with only errors has no content.
@SamHames SamHames added the bug label Apr 20, 2022
@edsu edsu self-assigned this Apr 28, 2022
edsu added a commit that referenced this issue Apr 28, 2022
@edsu
fixes #627
4732c39
@edsu
Copy link
Member

edsu commented Apr 28, 2022

@SamHames does this test reflect how you think it should behave?

@edsu edsu mentioned this issue Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edsu edsu

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

flattened errors DocNow/twarc
2 participants
@edsu @SamHames