-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the singular user command, analogous to the single tweet command #599
Conversation
The design mirrors the users command, so there's a --username flag to
handle that case explicitly.
Not sure that's necessarily the best approach for the long term, but it's
at least consistent with its sibling command.
Given how common that specific use case is do you think it's worth
considering another approach?
…On Tue, 22 Feb 2022, 23:13 Ed Summers, ***@***.***> wrote:
It looks like id works but username does not?
$ twarc2 user jack
⚡ The `ids` query parameter value [jack] is not valid
—
Reply to this email directly, view it on GitHub
<#599 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACADAUKOKIR3HXZCI3N4ISLU4ODZJANCNFSM5PAOK3PQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that looking up by username doesn't work?
$ twarc2 user jack
⚡ The `ids` query parameter value [jack] is not valid
Maybe that should be fixed or it shouldn't advertise that it can lookup by username?
yes, would be nice to have |
I added the name/id disambiguation as part of the command to make it clear, as well as updating the docstrings to better align with that.
|
I really like this |
I like it too! It could be useful for some other commands like |
I think this is good to go! |
This adds the user command, which takes a single user id. This is a direct analogue of the single tweet command, so we know have tweet/tweets and user/users.
Closes #598