Parse of "received" headers; keep all entries #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC2822 mentions that the trace fields will container "one or more Received: fields."
|
Thanks for the PR. Can you add a test case for this so we can track future regressions? |
|
I could, but now that I'm looking at the tests, there is one with a "received" check (which is failing with this change). |
|
Yes, I believe always being a list would be preferable |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had interest in maintaining a complete record of them in an experiment I'm working on, and thus needed some way to store them. RFC2822 mentions that the trace fields will contain "one or more Received: fields."
This is slightly related to #79. In order to find the "for" value in the trace, you need all of the received headers.