Fix isServiceFactory deprecation with Ember 1.13 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Ember 1.13, Ember expects that services either extend `Ember.Service`, or they must set `isServiceFactory` to `true` at the class level. Since the Cart service already extends `ArrayProxy`, this commit reopens the Cart service class to set `isServiceFactory` to `true`. See emberjs/ember.js#11261
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Ember 1.13, Ember expects that services either extend
Ember.Service, or they should setisServiceFactorytotrueat the class level. Since the Cart service already extendsArrayProxy, this commit reopens the Cart service class to setisServiceFactorytotrue.See emberjs/ember.js#11261
I noticed this from a deprecation warning in a 1.13.x ember app that depends on
ember-cart.