Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated '@ember/polyfills' #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcemira
Copy link

This pull request refactors the start-app.js test helper to remove the deprecated @ember/polyfills import and replace the merge function with the ES6 spread operator for merging objects.

Changes Made:

  • Removed the import statement for merge from @ember/polyfills.
  • Updated the merge function call to use the ES6 spread operator for merging default attributes with provided attributes.

Reason for Change:

  • The @ember/polyfills package has been deprecated, and using the ES6 spread operator is a modern and more efficient way to handle object merging. This change ensures compatibility with future Ember.js versions and removes reliance on deprecated functionality.

Impact:

  • No functionality changes.
  • Improved code readability.
  • Ensures compatibility with newer Ember.js versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant