Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6312 chrome 73 workaround for date picker and dropdowns #6314

Closed
wants to merge 1 commit into from

Conversation

blanchg
Copy link

@blanchg blanchg commented Mar 27, 2019

Proposed changes

Fix for issue #6312 to allow chrome 73 compatibility for date/time pickers and dropdowns

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closes: Dogfalo#6312
Adds timeouts to user interactions to workaround chrome 73 bug
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right solution as it does not delete the previous triggers. See my solution with dethrottling. See amsul/pickadate.js#1140

@blanchg blanchg closed this Apr 16, 2019
@blanchg
Copy link
Author

blanchg commented Apr 16, 2019

There isn't a nice way to solve this, any timeout used can be exceeded by the user holding the mouse down.

@blanchg blanchg deleted the 6312-chrome-73 branch April 16, 2019 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants