fix(rich-text-link): Change openOnClick default to whenNotEditable (

#744) feat(rich-text-link): Change `openOnClick` default to `whenNotEditable`
Doist · Apr 15, 2024 · db729d4 · db729d4
1 parent 6ffafa6
commit db729d4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/extensions/rich-text/rich-text-link.ts b/src/extensions/rich-text/rich-text-link.ts
@@ -63,6 +63,12 @@ function linkPasteRule(config: Parameters<typeof markPasteRule>[0]) {
  */
 const RichTextLink = Link.extend({
     inclusive: false,
+    addOptions() {
+        return {
+            ...this.parent?.(),
+            openOnClick: 'whenNotEditable' as LinkOptions['openOnClick'],
+        }
+    },
     addAttributes() {
         return {
             ...this.parent?.(),

diff --git a/stories/typist-editor/constants/defaults.ts b/stories/typist-editor/constants/defaults.ts
@@ -122,9 +122,6 @@ const DEFAULT_RICH_TEXT_KIT_OPTIONS: Partial<RichTextKitOptions> = {
     dropCursor: {
         class: 'ProseMirror-dropcursor',
     },
-    link: {
-        openOnClick: false,
-    },
     orderedList: {
         smartToggle: true,
     },