fix(deps): update tiptap packages to v2.1.6 #398

renovate · 2023-08-17T08:53:17Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@tiptap/core (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-blockquote (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-bold (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-bullet-list (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-character-count (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-code (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-code-block (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-document (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-dropcursor (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-gapcursor (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-hard-break (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-heading (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-history (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-horizontal-rule (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-image (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-italic (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-link (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-list-item (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-ordered-list (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-paragraph (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-placeholder (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-strike (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-task-item (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-task-list (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-text (source)	`2.0.4` -> `2.1.1`
@tiptap/extension-typography (source)	`2.0.4` -> `2.1.1`
@tiptap/pm (source)	`2.0.4` -> `2.1.1`
@tiptap/react (source)	`2.0.4` -> `2.1.1`
@tiptap/suggestion (source)	`2.0.4` -> `2.1.1`

This PR also:

Closes URL inside inline code is automatically converted into a link #319.
Helps fixing https://github.com/Doist/Issues/issues/6840.

Note
The @tiptap/extension-list-keymap extension will also introduce other keymap handlers for backspace altering the default backspace behavior. This could be unwanted and we'll need to monitor feedback.

Release Notes

ueberdosis/tiptap (@tiptap/core)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/core

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/core

ueberdosis/tiptap (@tiptap/extension-blockquote)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-blockquote

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-blockquote

ueberdosis/tiptap (@tiptap/extension-bold)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-bold

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-bold

ueberdosis/tiptap (@tiptap/extension-bullet-list)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-bullet-list

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-bullet-list

ueberdosis/tiptap (@tiptap/extension-character-count)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-character-count

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-character-count

ueberdosis/tiptap (@tiptap/extension-code)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-code

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-code

ueberdosis/tiptap (@tiptap/extension-code-block)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-code-block

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-code-block

ueberdosis/tiptap (@tiptap/extension-document)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-document

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-document

ueberdosis/tiptap (@tiptap/extension-dropcursor)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-dropcursor

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-dropcursor

ueberdosis/tiptap (@tiptap/extension-gapcursor)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-gapcursor

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-gapcursor

ueberdosis/tiptap (@tiptap/extension-hard-break)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-hard-break

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-hard-break

ueberdosis/tiptap (@tiptap/extension-heading)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-heading

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-heading

ueberdosis/tiptap (@tiptap/extension-history)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-history

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-history

ueberdosis/tiptap (@tiptap/extension-horizontal-rule)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-horizontal-rule

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-horizontal-rule

ueberdosis/tiptap (@tiptap/extension-image)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-image

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-image

ueberdosis/tiptap (@tiptap/extension-italic)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-italic

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-italic

ueberdosis/tiptap (@tiptap/extension-link)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-link

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-link

ueberdosis/tiptap (@tiptap/extension-list-item)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-list-item

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-list-item

ueberdosis/tiptap (@tiptap/extension-ordered-list)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-ordered-list

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-ordered-list

ueberdosis/tiptap (@tiptap/extension-paragraph)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-paragraph

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-paragraph

ueberdosis/tiptap (@tiptap/extension-placeholder)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-placeholder

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-placeholder

ueberdosis/tiptap (@tiptap/extension-strike)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-strike

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-strike

ueberdosis/tiptap (@tiptap/extension-task-item)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-task-item

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-task-item

ueberdosis/tiptap (@tiptap/extension-task-list)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-task-list

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-task-list

ueberdosis/tiptap (@tiptap/extension-text)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-text

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-text

ueberdosis/tiptap (@tiptap/extension-typography)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/extension-typography

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/extension-typography

ueberdosis/tiptap (@tiptap/pm)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/pm

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/pm

ueberdosis/tiptap (@tiptap/react)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/react

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/react

ueberdosis/tiptap (@tiptap/suggestion)

`v2.1.1`

Compare Source

Note: Version bump only for package @tiptap/suggestion

`v2.1.0`

Compare Source

Note: Version bump only for package @tiptap/suggestion

Configuration

📅 Schedule: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

netlify · 2023-08-17T08:53:31Z

✅ Deploy Preview for doist-typist ready!

Name	Link
🔨 Latest commit	`7662169`
🔍 Latest deploy log	https://app.netlify.com/sites/doist-typist/deploys/64e6234b36d861000812798d
😎 Deploy Preview	https://deploy-preview-398--doist-typist.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

renovate · 2023-08-17T09:59:23Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

rfgamaral · 2023-08-17T10:16:43Z

PR Observations

Closes URL inside inline code is automatically converted into a link #319, but Todoist/Twist will need to be updated with a new Typist version for the fix to be applied to our products
Will help fix https://github.com/Doist/Issues/issues/6840 (and other list related issues) once a new Typist version is pushed to Todoist/Twist
- Note
  The @tiptap/extension-list-keymap extension will also introduce other keymap handlers for backspace altering the default backspace behavior. This could be unwanted and we'll need to monitor feedback.
The default strikethrough shortcut has been changed from ⌘+⇧+X/Ctrl+⇧+X to ⌘+⇧+S/Ctrl+⇧+S, which is a more standardized version similar to other apps (Notion, Dropbox Paper), but we are keeping the old shortcut (ref)

rfgamaral · 2023-08-17T10:39:40Z

@nats12 This PR was created by Renovate and that's why it doesn't have the normal PR structure and no test plan. However, for a test plan, just play with the rich-text editor stories, see if you can find anything unexpected or not working, and double-check the issues that I mentioned in the comment above.

@Doist/frontend-product It would be nice if at least someone else besides me and Natalie (assigned reviwer) could also take this for a spin. We all use the editor/composer in different ways, and the more people that test these changes, the merrier.

@domjost The long standing bullet list issues have been fixed here (there might be some quirks here and there, but it's much better now). Just letting you know in case you want to take a look before we push this to our products.

Everyone, use the Netlify deploy preview for testing:

https://deploy-preview-398--doist-typist.netlify.app/

jvalente · 2023-08-17T11:04:50Z

It would be nice if at least someone else besides me and Natalie (assigned reviwer) could also take this for a spin.

@rfgamaral is there a particular use case or test plan that you'd like us to follow?

rfgamaral · 2023-08-17T11:13:07Z

@jvalente Besides the issues mentioned here, nothing in particular. Those are the issues that we have logged on our side, and have been fixed with this new tiptap version. But it also brought many other bug fixes and improvements, and I just wanted to double-check that we are not introducing any annoying bug with this new version.

So, take the editor for a quick spin, try to use it as you normally would in Todoist/Twist, and see if you can break it somehow 😅

jvalente · 2023-08-17T12:07:27Z

Can confirm that the update addresses the mentioned issues. 👍
Could not detect any unexpected behavior while smoketesting the preview.

nats12

@rfgamaral I've tested the above mentioned issues and all seem to be addressed except for the inline code URL one. The below is not what we expect, right?

Steps to reproduce:

Open ` mark and enter some text plus a url
Close ` mark

The closing of the code mark after the url seems to place it after the text, and adds the url in its own inline code block.

rfgamaral · 2023-08-17T14:19:41Z

The below is not what we expect, right?

Yes, I believe that should've been fixed.

I couldn't reproduce it myself following your test steps. I could, however, reproduce it by pasting a URL (instead of typing), but that's a completyly different issue.

Typing:

firefox_REjjM6jVtW.mp4

Pasting:

firefox_Dzqpk6N97X.mp4

So, in a nutshell, typing should be fixed, pasting is a different (non-logged) issue.

Can you please confirm if you typed or pasted? If you typed, can you reproduce the issue consistently? Can you post a demo?

rfgamaral · 2023-08-17T14:36:29Z

@jvalente @nats12 A decision came through and we are keeping the default ⌘ + ⇧ + X / Ctrl + ⇧ + X shortcut for strikethrough formatting (which required a new custom extension). I've pushed a change, and already tested this on Windows with Ctrl, but if you could double-check the ⌘ on macOS, I'd appreciate it.

jvalente · 2023-08-18T07:46:03Z

⌘ + ⇧ + X toggles strikethrough.
⌘ + ⇧ + S does not. 👍

nats12 · 2023-08-18T14:12:33Z

Can you please confirm if you typed or pasted? If you typed, can you reproduce the issue consistently? Can you post a demo?

My apologies, I did indeed paste! I can confirm the issue is fixed when typing 👍🏼

I also re-tested the strikethrough, it works again with the default.

## [1.4.5](v1.4.4...v1.4.5) (2023-08-23) ### Bug Fixes * **deps:** update tiptap packages to v2.1.6 ([#398](#398)) ([08d1f6a](08d1f6a))

doistbot · 2023-08-23T15:22:49Z

🎉 This PR is included in version 1.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

renovate bot added the dependencies Pull requests that update a dependency file label Aug 17, 2023

renovate bot enabled auto-merge (squash) August 17, 2023 08:53

renovate-approve bot approved these changes Aug 17, 2023

View reviewed changes

rfgamaral disabled auto-merge August 17, 2023 08:59

rfgamaral self-assigned this Aug 17, 2023

rfgamaral force-pushed the renovate/tiptap-packages branch from b2a384c to 27cb57d Compare August 17, 2023 09:59

rfgamaral requested review from a team, rfgamaral and nats12 and removed request for a team and rfgamaral August 17, 2023 10:34

rfgamaral added the 🙋 Ask PR Used for PRs that need a review before merging. label Aug 17, 2023

jvalente self-requested a review August 17, 2023 11:42

jvalente approved these changes Aug 17, 2023

View reviewed changes

nats12 reviewed Aug 17, 2023

View reviewed changes

rfgamaral force-pushed the renovate/tiptap-packages branch from 27cb57d to 9fd1b15 Compare August 17, 2023 14:33

nats12 self-requested a review August 18, 2023 14:12

nats12 approved these changes Aug 18, 2023

View reviewed changes

rfgamaral changed the title ~~fix(deps): update tiptap packages to v2.1.1~~ fix(deps): update tiptap packages to v2.1.3 Aug 18, 2023

rfgamaral force-pushed the renovate/tiptap-packages branch from ccee5e7 to 803c666 Compare August 18, 2023 21:33

rfgamaral changed the title ~~fix(deps): update tiptap packages to v2.1.3~~ fix(deps): update tiptap packages to v2.1.6 Aug 21, 2023

rfgamaral force-pushed the renovate/tiptap-packages branch from 803c666 to 48c50f8 Compare August 23, 2023 15:10

rfgamaral enabled auto-merge (squash) August 23, 2023 15:10

renovate bot and others added 5 commits August 23, 2023 16:17

fix(deps): update tiptap packages to v2.1.1

8b1e608

Fix broken <TypistEditor> unit tests

5f80ae7

Add ListKeymap extension for better list handling

fda32ef

Add custom RichTextStrikethrough extension to restore the old shortcut

511063a

fix(deps): update tiptap packages to v2.1.6

7662169

rfgamaral force-pushed the renovate/tiptap-packages branch from 48c50f8 to 7662169 Compare August 23, 2023 15:17

rfgamaral merged commit 08d1f6a into main Aug 23, 2023

rfgamaral deleted the renovate/tiptap-packages branch August 23, 2023 15:19

doistbot added a commit that referenced this pull request Aug 23, 2023

chore(release): 1.4.5 [skip ci]

fe652ac

## [1.4.5](v1.4.4...v1.4.5) (2023-08-23) ### Bug Fixes * **deps:** update tiptap packages to v2.1.6 ([#398](#398)) ([08d1f6a](08d1f6a))

doistbot added the released Pull requests that have been released to production label Aug 23, 2023

rfgamaral mentioned this pull request Sep 4, 2023

fix(rich-text-kit): Allow the ListKeymap extension to be configured #426

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update tiptap packages to v2.1.6 #398

fix(deps): update tiptap packages to v2.1.6 #398

renovate bot commented Aug 17, 2023 •

edited by rfgamaral

Loading

netlify bot commented Aug 17, 2023 •

edited

Loading

renovate bot commented Aug 17, 2023

rfgamaral commented Aug 17, 2023 •

edited

Loading

rfgamaral commented Aug 17, 2023

jvalente commented Aug 17, 2023

rfgamaral commented Aug 17, 2023 •

edited

Loading

jvalente commented Aug 17, 2023 •

edited

Loading

nats12 left a comment •

edited

Loading

rfgamaral commented Aug 17, 2023

rfgamaral commented Aug 17, 2023 •

edited

Loading

jvalente commented Aug 18, 2023

nats12 commented Aug 18, 2023

doistbot commented Aug 23, 2023

fix(deps): update tiptap packages to v2.1.6 #398

fix(deps): update tiptap packages to v2.1.6 #398

Conversation

renovate bot commented Aug 17, 2023 • edited by rfgamaral Loading

Release Notes

Configuration

netlify bot commented Aug 17, 2023 • edited Loading

✅ Deploy Preview for doist-typist ready!

renovate bot commented Aug 17, 2023

Edited/Blocked Notification

rfgamaral commented Aug 17, 2023 • edited Loading

PR Observations

rfgamaral commented Aug 17, 2023

jvalente commented Aug 17, 2023

rfgamaral commented Aug 17, 2023 • edited Loading

jvalente commented Aug 17, 2023 • edited Loading

nats12 left a comment • edited Loading

Choose a reason for hiding this comment

rfgamaral commented Aug 17, 2023

rfgamaral commented Aug 17, 2023 • edited Loading

jvalente commented Aug 18, 2023

nats12 commented Aug 18, 2023

doistbot commented Aug 23, 2023

renovate bot commented Aug 17, 2023 •

edited by rfgamaral

Loading

netlify bot commented Aug 17, 2023 •

edited

Loading

rfgamaral commented Aug 17, 2023 •

edited

Loading

rfgamaral commented Aug 17, 2023 •

edited

Loading

jvalente commented Aug 17, 2023 •

edited

Loading

nats12 left a comment •

edited

Loading

rfgamaral commented Aug 17, 2023 •

edited

Loading