feat(commands)!: Add insertMarkdownContentAt command
#439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfgamaral
requested review from
craigcarlyle
and removed request for
a team
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rfgamaral
force-pushed
the
ricardo/insert-markdown-content-at
branch
from
effb41e to
8e8ab30
Compare
BREAKING CHANGE: With the introduction of `insertMarkdownContentAt`, the API for `insertMarkdownContent` was changed to match the Tiptap's implementation of `insertContent`/`insertContentAt`, which the `insertMarkdown*` commands draw inspiration from.
rfgamaral
force-pushed
the
ricardo/insert-markdown-content-at
branch
from
8e8ab30 to
0835d97
Compare
craigcarlyle
approved these changes
Sep 12, 2023
doistbot
added a commit
that referenced
this pull request
Sep 13, 2023
## [2.0.0](v1.5.0...v2.0.0) (2023-09-13) ### ⚠ BREAKING CHANGES * **commands:** With the introduction of `insertMarkdownContentAt`, the API for `insertMarkdownContent` was changed to match the Tiptap's implementation of `insertContent`/`insertContentAt`, which the `insertMarkdown*` commands draw inspiration from. ### Features * **commands:** Add `insertMarkdownContentAt` command ([#439](#439)) ([e87b892](e87b892))
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces the
insertMarkdownContentAtcommand, which does the same as theinsertMarkdownContentthat we already have but allows one to pick the insertion position in the document. With the introduction of this command,insertMarkdownContentwas changed to useinsertMarkdownContentAt, and use the same API as the matching pairinsertContent/insertContentAtfrom Tiptap, which theinsertMarkdown*commands draw inspiration from.Although the API for
insertMarkdownContentchanged - thus making this a breaking change - it doesn't affect our products because we are not using the part of the API that actually changed (the second parameter). But since it's technically a breaking change, it is being marked as such.As mentioned above, the
insertMarkdown*commands are inspired by theinsertContent*commands from Tiptap, and do pretty much the same things in the same way, but adapted to insert Markdown instead of plain-text or HTML.PR Checklist
Test plan
Rich-text → Functions → CommandsstoryinsertMarkdownContentbuttoninserMarkdownContentbuttoninserMarkdownContentAtbutton