fix: Check table element before pasting it as a string #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@rfgamaral what's the process to create a new release? Will it work by just merging this PR? |
rfgamaral
changed the title
@gnapse Yes 😊 |
rfgamaral
force-pushed
the
ernesto/check-table-element-1
branch
from
4825e4f to
0c88719
Compare
doistbot
added a commit
that referenced
this pull request
Dec 11, 2024
## [7.0.4](v7.0.3...v7.0.4) (2024-12-11) ### Bug Fixes * Check table element before pasting it as a string ([#977](#977)) ([954568e](954568e))
|
🎉 This PR is included in version 7.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We're getting this error in Sentry, pointed to this library.
The stack trace points to the line that calls
Array.from(tableElement.rows).PR Checklist
README.mdTest plan
We do not know how to reproduce this. But hopefully the changes make sense.
Part of the key to accept these changes is the removal of the type coercion on the return value of
parseHtmlToElement. It is safer to not do that, and then check that the returned element is an instance ofHTMLTableElement. On top of that, as an extra check, I added the condition to check thattableElement.rowsis not a falsy value.