Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improved discord webhooks notifications style #793

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

190km
Copy link
Contributor

@190km 190km commented Dec 1, 2024

Now, discord notifications are easier to read and to understand, here are a few examples

{0A57EB32-9C3A-406C-9C8E-03706ECF8A4C}
{21D2BEE2-86FF-48FD-BF29-AACD8CF628EF}
{619305C9-3297-4295-80AA-30D5E5630953}
image

@190km 190km requested a review from Siumauricio as a code owner December 1, 2024 03:22
@TheOnlyWayUp
Copy link

Eh, I'm not a fan of everything being codeblocked. The emojis in embed names are okay, but I like how errors are codeblocked - that's a good idea.

Maybe build links could be hyperlinked? Like so,
Build Link
It doesn't have to be an entirely new field.

@190km
Copy link
Contributor Author

190km commented Dec 1, 2024

Removed code block for other fields, now its only for error message.

Database Backup Failed

{EA14CED2-F1CF-44D2-9D1C-4B0A58B3B07D}

Build Successful

{DF989DD9-6030-48AA-88FE-0F6D273E595B}

Build Failed

{60369CAA-DB05-4745-A92D-1FEA9BF39179}

@Siumauricio Siumauricio merged commit f10eae4 into Dokploy:canary Dec 3, 2024
3 checks passed
@190km 190km deleted the discord-notifications branch December 3, 2024 07:35
@Siumauricio Siumauricio mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants